Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyAccess] Document nullsafe operator usage#17288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fsoedjede
Copy link
Contributor

@fsoedjedefsoedjedeforce-pushed the34483-document-property-access-nullsafe-operator-usage branch from976033c to6a5d2eeCompareSeptember 22, 2022 22:56
@javiereguiluzjaviereguiluz added PropertyAccess Waiting Code MergeDocs for features pending to be merged labelsSep 23, 2022
@javiereguiluzjaviereguiluz added this to thenext milestoneSep 23, 2022
@carsonbotcarsonbot changed the title[WCM][PropertyAccess] Document nullsafe operator usage[PropertyAccess] [WCM] Document nullsafe operator usageSep 23, 2022
fabpot added a commit to symfony/symfony that referenced this pull requestOct 1, 2022
…s (fsoedjede)This PR was merged into the 6.2 branch.Discussion----------[Form][PropertyAccess] Allow optional property accesses| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#34483 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        |symfony/symfony-docs#17288 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->This PR is basically a copy of#34497 with some minor changes.I needed it and I have some time now to help advance in implementing it.**TODO**- [x] Add nullsafe operator usage- [x] Update unit test- [x] Update documentationRegardsCommits-------6455feb feature#34483 - Allow optional property accesses
symfony-splitter pushed a commit to symfony/form that referenced this pull requestOct 1, 2022
…s (fsoedjede)This PR was merged into the 6.2 branch.Discussion----------[Form][PropertyAccess] Allow optional property accesses| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | Fix #34483 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        |symfony/symfony-docs#17288 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->This PR is basically a copy of #34497 with some minor changes.I needed it and I have some time now to help advance in implementing it.**TODO**- [x] Add nullsafe operator usage- [x] Update unit test- [x] Update documentationRegardsCommits-------6455febec6 feature #34483 - Allow optional property accesses
@fsoedjedefsoedjede marked this pull request as ready for reviewOctober 1, 2022 16:59
@carsonbotcarsonbot modified the milestones:next,6.2Oct 1, 2022
@fsoedjedefsoedjede changed the title[PropertyAccess] [WCM] Document nullsafe operator usage[PropertyAccess] Document nullsafe operator usageOct 1, 2022
@javiereguiluzjaviereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code MergeDocs for features pending to be merged labelsOct 4, 2022
@javiereguiluzjaviereguiluz modified the milestones:next,6.2Oct 4, 2022
@javiereguiluzjaviereguiluz merged commitdabd9ce intosymfony:6.2Oct 4, 2022
@javiereguiluz
Copy link
Member

Felix, thanks a lot for this contribution.

Please note that while merging we made some changes: we moved some contents and introduced some rewords (see4c55db3) but most of your original contribution remained. Thanks!

@fsoedjedefsoedjede deleted the 34483-document-property-access-nullsafe-operator-usage branchOctober 6, 2022 21:06
@fsoedjede
Copy link
ContributorAuthor

No problem@javiereguiluz
The rewording looks better.
Thanks

javiereguiluz reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@fsoedjede@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp