Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[PropertyAccess] Document nullsafe operator usage#17288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:6.2fromfsoedjede:34483-document-property-access-nullsafe-operator-usageOct 4, 2022
Merged
[PropertyAccess] Document nullsafe operator usage#17288
javiereguiluz merged 1 commit intosymfony:6.2fromfsoedjede:34483-document-property-access-nullsafe-operator-usageOct 4, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 tasks
976033c to6a5d2eeComparefabpot added a commit to symfony/symfony that referenced this pull requestOct 1, 2022
…s (fsoedjede)This PR was merged into the 6.2 branch.Discussion----------[Form][PropertyAccess] Allow optional property accesses| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#34483 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR |symfony/symfony-docs#17288 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->This PR is basically a copy of#34497 with some minor changes.I needed it and I have some time now to help advance in implementing it.**TODO**- [x] Add nullsafe operator usage- [x] Update unit test- [x] Update documentationRegardsCommits-------6455feb feature#34483 - Allow optional property accesses
symfony-splitter pushed a commit to symfony/form that referenced this pull requestOct 1, 2022
…s (fsoedjede)This PR was merged into the 6.2 branch.Discussion----------[Form][PropertyAccess] Allow optional property accesses| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | Fix #34483 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR |symfony/symfony-docs#17288 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->This PR is basically a copy of #34497 with some minor changes.I needed it and I have some time now to help advance in implementing it.**TODO**- [x] Add nullsafe operator usage- [x] Update unit test- [x] Update documentationRegardsCommits-------6455febec6 feature #34483 - Allow optional property accesses
Member
javiereguiluz commentedOct 4, 2022
Felix, thanks a lot for this contribution. Please note that while merging we made some changes: we moved some contents and introduced some rewords (see4c55db3) but most of your original contribution remained. Thanks! |
ContributorAuthor
fsoedjede commentedOct 6, 2022
No problem@javiereguiluz |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc PR forsymfony/symfony#47511