Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Replace remaining annotations with attributes, remove remaining annotations configuration block#17223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -81,8 +81,8 @@ with the ``User`` class:: | |||
| } | |||
| } | |||
| Beware that this feature is already provided by the `@ParamConverter`_ | |||
| annotation from the SensioFrameworkExtraBundle. If you have that bundle | |||
| Beware that this feature is already provided by the `#[ParamConverter]`_ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we refer to theMapEntity (seesymfony/symfony#43854) here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, I would be in favor of changing the whole Custom Value Resolver example because there is already a native UserValueResolver. But I don't know what could be used instead!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's keep it as is then for now and rethink the whole example in a different PR.
…ations configuration block
1cacb5b to6c15670CompareThank you Romain. |
This PR replaces the last remaining annotations in the documentation with the attributes.
I think this is the last PR tofix#16877, unless I missed some other annotations.