[DependencyInjection] Add docs for`SubscribedService::$attributes`#17211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:6.2fromkbond:service-subscriber-attributes

Sep 21, 2022

Merged

[DependencyInjection] Add docs for`SubscribedService::$attributes`#17211

javiereguiluz merged 1 commit intosymfony:6.2fromkbond:service-subscriber-attributes

Sep 21, 2022

Conversation

Copy link

Member

kbond commentedAug 19, 2022

Fixes#17208.

carsonbot added Status: Needs Review DependencyInjection labels

Aug 19, 2022

carsonbot added this to the6.2 milestone

Aug 19, 2022

Copy link

MemberAuthor

kbond commentedAug 19, 2022•
edited
Loading

One potential problem with this feature is it will require the latest version ofsymfony/service-contracts (3.2+) butsymfony/dependency-injection currently allows older versions.

Basically, a user could havesymfony/dependency-injection 6.2 butsymfony/service-contracts 3.1. This feature will not work in this case.

[DI] add docs forSubscribedService::$attributes

b6aa127

kbond force-pushed theservice-subscriber-attributes branch frombc1382f tob6aa127Compare

August 19, 2022 15:40

Copy link

Contributor

mdoutreluingne commentedAug 20, 2022

I think it would be interesting here to mention that this feature requiressymfony/service-contracts (3.2+), because in your example there may be a case where this feature would not work depending on the version ofsymfony/service-contracts.