Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Add messenger rate_limiter docs#17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:6.3frombobvandevijver:patch-2
Dec 14, 2023

Conversation

@bobvandevijver
Copy link
Contributor

Documentation forsymfony/symfony#41171

..caution::

When a rate limiter is configured on a transport, it will block the whole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about such wordings?

As a rate limiter on a transport will block its worker from consuming when the limit is hit,
you may run a dedicated worker handling such transport to avoid others being blocked.

(Perhaps the english is not perfect) but commenting for the idea

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think both are good, it is just a personal preference thing. I don't mind changing it, I also don't mind keeping it as is.

averatec1337 and 94noni reacted with thumbs up emoji
@ghost
Copy link

Let's merge it after over a year.

bobvandevijver and walva reacted with thumbs up emoji

@walva
Copy link
Contributor

Just came through this, very helpful.
I reconciliate 10k+ stripe payment, and it was indeed what I was looking for.

@carsonbotcarsonbot changed the titleAdd messenger rate_limiter docs[Messenger] Add messenger rate_limiter docsDec 14, 2023
@OskarStarkOskarStark modified the milestones:5.4,6.3Dec 14, 2023
@OskarStark
Copy link
Contributor

It took time, but here we go, this is in now. Thank you very much@bobvandevijver.

bobvandevijver reacted with hooray emoji

@OskarStarkOskarStark merged commitfa4e20f intosymfony:6.3Dec 14, 2023
@bobvandevijverbobvandevijver deleted the patch-2 branchDecember 14, 2023 08:30
@walva
Copy link
Contributor

Than you@OskarStark

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotAwaiting requested review from fabpot

@94noni94noniAwaiting requested review from 94noni

1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

7 participants

@bobvandevijver@walva@OskarStark@fabpot@94noni@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp