Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Mailer] add new events#17181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Mailer] add new events#17181
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mailer.rst Outdated
| ..versionadded::6.2 | ||
| ``SentMessageEvent`` and ``FailedMessageEvent`` was introduced in Symfony 6.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
were introduced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
mailer.rst Outdated
| SentMessageEvent | ||
| ~~~~~~~~~~~~ | ||
| ``SentMessageEvent`` it allows acting on the:class:`Symfony\\Component\\Mailer\\SentMessage`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps document like this?
https://symfony.com/doc/current/reference/events.html#kernel-request
When and why and what can be done in it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea !
Personally I like it when it's uniform (it's simpler and nicer to read). So I standardized likehttps://symfony.com/doc/current/reference/events.html#kernel-request
I have detailed this event. Thanks for your review
12033eb to5c545bdComparejaviereguiluz commentedSep 20, 2022
Nice contribution! Thanks Maxime ... and thanks to reviewers too! |
Fixes#17071