Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Notifier][Testing] Document the notifier assertions#17116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh added a commit to symfony/symfony that referenced this pull requestAug 6, 2022
…(javiereguiluz)This PR was merged into the 6.2 branch.Discussion----------[Notifier] Rename some arguments in notifier assertions| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | if this is merged, I'll updatesymfony/symfony-docs#17116While documenting#46895, I thought about renaming some arguments. So here's a PR with that proposal for your consideration. Thanks.Commits-------b5178dd [Notifier] Rename some arguments in notifier assertions
OskarStark approved these changesAug 7, 2022
javiereguiluz added a commit that referenced this pull requestAug 8, 2022
…viereguiluz)This PR was squashed before being merged into the 6.2 branch.Discussion----------[Notifier][Testing] Document the notifier assertionsFixes#17057.Don't merge until a decision is made onsymfony/symfony#47204Commits-------497fb5d [Notifier][Testing] Document the notifier assertions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#17057.
Don't merge until a decision is made onsymfony/symfony#47204