Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Mailer] Add more information about sending email async#17065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Thanks to this, instead of being delivered immediately, messages will be sent to | ||
| the transport to be handled later (see:ref:`messenger-worker`). | ||
| ..versionadded::6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Imho this should be a warning, otherwise it gets removed in Symfony 7 docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Having this removed in 7.0 is a good thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done then
Uh oh!
There was an error while loading.Please reload this page.
…e (fabpot)This PR was merged into the 6.2 branch.Discussion----------[Mime] Change the way we avoid rendering an email twice| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | yes-ish| New feature? | yes-ish <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR |symfony/symfony-docs#17065Trying to kill several birds with one stone here.I was not very happy with the way we ensured that emails were not renderer more than once.This solution seems easier and allows for people to render an email **before** sending it to Messenger (important when you have Doctrine entities in the context for instance) as documented in the related doc PR.Commits-------cc3b871 [Mime] Change the way we avoid rendering an email twice
fabpot commentedJul 27, 2022
Related PR has been merged now. |
javiereguiluz commentedJul 27, 2022
Thank you Fabien. |
Uh oh!
There was an error while loading.Please reload this page.
The example only works as of 6.2 thanks tosymfony/symfony#47075
I've written this PR because we keep having issues likesymfony/symfony#44439.
So, documenting a bit more how it works internally might help people understand what to do.