Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Allow configuring a target url when switching user#17024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@94noni
Copy link
Contributor

@94noni94noni commentedJul 21, 2022
edited
Loading

Documentssymfony/symfony#47343
Supersedsymfony/symfony#46338 (feature changed)
Close#17021

@carsonbotcarsonbot added this to the6.2 milestoneJul 21, 2022
@xabbuh
Copy link
Member

looking at the example configuration I wonder if being able to configure a route name wouldn't be more sensible in most cases than having to configure the URL (path)

@94noni
Copy link
ContributorAuthor

looking at the example configuration I wonder if being able to configure a route name wouldn't be more sensible in most cases than having to configure the URL (path)

I see, I've inspired myself with thelogin default_target_path iirc

swapping to a route name, what changes will be necessary on the code side? injecting the router that's all?

@xabbuh
Copy link
Member

swapping to a route name, what changes will be necessary on the code side? injecting the router that's all?

injecting aUrlGeneratorInterface should be enough, yes

@94noni
Copy link
ContributorAuthor

@xabbuh got it

I’ll try to handle the code change in the next days, and then rewrite this doc entry

Status: needs work

xabbuh reacted with thumbs up emoji

@94noni
Copy link
ContributorAuthor

94noni commentedSep 13, 2022
edited
Loading

I’ll try to handle the code change in the next days, and then rewrite this doc entry

its finally done@xabbuh :)
status: needs review

many thanks

@94noni
Copy link
ContributorAuthor

I am afk so easier to accept suggested changes than using phone editor

@carsonbotcarsonbot changed the titleAllow configuring a target url when switching user[Security] Allow configuring a target url when switching userSep 20, 2022
@javiereguiluz
Copy link
Member

Thanks Antoine.

94noni reacted with thumbs up emoji

@javiereguiluzjaviereguiluz merged commit4f5b7f3 intosymfony:6.2Sep 20, 2022
@94noni94noni deleted the doc-switch-user-target-url branchSeptember 20, 2022 09:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[Security] Allow configuring a target url when switching user

6 participants

@94noni@xabbuh@javiereguiluz@OskarStark@maxhelias@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp