Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Document theterminate_on_cache_hit option#16999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.2fromjaviereguiluz:fix_16919
Oct 5, 2022

Conversation

@javiereguiluz
Copy link
Member

Fixes#16919.

@javiereguiluzjaviereguiluz added this to the6.2 milestoneJul 18, 2022
@carsonbotcarsonbot changed the titleDocument the terminate_on_cache_hit option[HttpKernel] Document the terminate_on_cache_hit optionJul 18, 2022
@javiereguiluz
Copy link
MemberAuthor

Thanks for your review Christian. I'm very confused, so I don't know how to move forward. Is this an internal thing that shouldn't be documented ... or is there something missing in the docs to make this option more useful? Thanks!

@OskarStarkOskarStark changed the title[HttpKernel] Document the terminate_on_cache_hit option[HttpKernel] Document theterminate_on_cache_hit optionJul 22, 2022
@javiereguiluz
Copy link
MemberAuthor

I'm closing this PR because I don't know how to move forward and it's better than others take over this. Thanks!

@wouterj
Copy link
Member

wouterj commentedSep 20, 2022•
edited
Loading

@javiereguiluz you can reopen this PR and only revert all changes fromcomponents/http_foundation.rst. All other changes are valid oncesymfony/symfony#47630 is merged (and I'm certain that it will be merged before 6.2 stable).

xabbuh reacted with heart emoji

@fabpotfabpot reopened thisSep 20, 2022
fabpot added a commit to symfony/symfony that referenced this pull requestSep 20, 2022
…e_on_cache_hit HttpCache option (wouterj)This PR was merged into the 6.2 branch.Discussion----------[FrameworkBundle] Add semantic config for new terminate_on_cache_hit HttpCache option| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#16999Adds the semantic configuration for the option introduced in Symfony 6.2 by#46763Commits-------bb387e9 [FrameworkBundle] Add semantic config for new terminate_on_cache_hit HttpCache option
@javiereguiluz
Copy link
MemberAuthor

I've reverted the wrong changes. Thanks for your review!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@wouterjwouterjAwaiting requested review from wouterj

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[HttpCache] Do not call terminate() on cache hit

6 participants

@javiereguiluz@wouterj@OskarStark@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp