Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors (with promoted property)#16954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR conflicts with#16955.
Why sending two PRs to fix one issue? Maybe two commits would be more appropriate?
alexandre-daubois commentedJul 8, 2022
That's right@HeahDude, in fact I'm even wondering if it really worth having this PR pointing out pormoted properties and if the other PR is actually enough? |
alexandre-daubois commentedJul 8, 2022
Kind of duplicate of#16955, I think it is not worth having this second PR just for promoted properties. Feel free to reopen if you don't agree! 👍 |
Resolves#16730