Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix doc service deprecation#16952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@94noni
Copy link
Contributor

Hi,
Based onthis PR, I've followedthe doc

But when tests executed, I gotthis error

So I propose to fix the doc accordingly here

Thank you

alexislefebvre reacted with thumbs up emoji
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should target 5.4, mentioning that passing only one argument is deprecated since 5.1 (refsymfony/symfony#35778)

94noni reacted with thumbs up emoji
@javiereguiluzjaviereguiluz changed the base branch from6.0 to5.4July 8, 2022 13:54
@javiereguiluzjaviereguiluzforce-pushed thefix-doc-service-deprecation branch from6026bf8 toffdb7e6CompareJuly 8, 2022 13:55
@javiereguiluzjaviereguiluz merged commit4fa18aa intosymfony:5.4Jul 8, 2022
@javiereguiluz
Copy link
Member

Thanks Antoine for the contribution!

Thanks Jules for the review. We did those tweaks while merging. See976422a

HeahDude and 94noni reacted with thumbs up emoji

@94noni94noni deleted the fix-doc-service-deprecation branchJuly 8, 2022 15:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuh

1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@94noni@javiereguiluz@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp