Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer]max_per_second option configurable via DSN#16800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.2fromgassan:max-per-second
Aug 9, 2022

Conversation

@gassan
Copy link
Contributor

AbstractTransport::setMaxPerSecond(float) was introduces in 5.1 but wan not configurable by dsn

@OskarStark
Copy link
Contributor

was introduces in 5.1 but wan not configurable by dsn

Please target5.4 branch then an addversionadded:: 5.1, thanks

@gassan
Copy link
ContributorAuthor

gassan commentedMay 17, 2022•
edited
Loading

According tosymfony/symfony#46315 (comment) the patch should be merged into 6.1 branch.
P.S. Whereby I think that the patch could also be merged into 5.4.

@OskarStark
Copy link
Contributor

Sorry I misread the PR header, you introduce the ability to set it via DSN in 6.1, but as its freezes, it should target 6.2 👍

gassan reacted with thumbs up emoji

@OskarStarkOskarStark modified the milestones:5.4,nextMay 17, 2022
@OskarStarkOskarStark added the Waiting Code MergeDocs for features pending to be merged labelMay 17, 2022
@OskarStarkOskarStark changed the titlemade max_per_second option configurable by dsnmax_per_second option configurable via DSNMay 20, 2022
@carsonbotcarsonbot changed the titlemax_per_second option configurable via DSN[Mailer]max_per_second option configurable via DSNMay 20, 2022
@OskarStark
Copy link
Contributor

Please rebase on6.2, thanks

@gassangassan changed the base branch from6.1 to6.2June 3, 2022 10:13
@gassan
Copy link
ContributorAuthor

Rebased onto 6.2

OskarStark reacted with rocket emoji

fabpot added a commit to symfony/symfony that referenced this pull requestJul 20, 2022
…(gassan)This PR was merged into the 6.2 branch.Discussion----------[Mailer] `max_per_second` option configurable via DSN| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#16800This option is available since 5.1, but it was impossible to configure it by dsn.Commits-------a377f2e made max_per_second option configurable by dsn
symfony-splitter pushed a commit to symfony/mailer that referenced this pull requestJul 20, 2022
…(gassan)This PR was merged into the 6.2 branch.Discussion----------[Mailer] `max_per_second` option configurable via DSN| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#16800This option is available since 5.1, but it was impossible to configure it by dsn.Commits-------a377f2e104 made max_per_second option configurable by dsn
@javiereguiluzjaviereguiluz added Waiting feedback and removed Waiting Code MergeDocs for features pending to be merged labelsJul 29, 2022
@javiereguiluzjaviereguiluz modified the milestones:next,6.2Jul 29, 2022
@javiereguiluz
Copy link
Member

Gassan, thanks and congrats on your first Symfony Docs contribution 🎉

gassan reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@gassan@OskarStark@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp