Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] adjustAutowire attribute docs#16779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have a suggestion about this sentence:
"You can also use the#[Autowire] parameter attribute to configure the problematic arguments:"
I think it would be better to use the verb "hint" or "instruct" instead of "configure".
The reason is that "configure" is a bit overloaded here:
- configure service definitions explicitly
- configure the autowiring process (here we refer to this)
With this in mind, what about eg "You can also use the#[Autowire] parameter attribute to hint the autowiring logic about those arguments:"
kbond commentedMay 4, 2022
I went with "instructs". |
3ad96fd tofd05739Comparejaviereguiluz commentedMay 4, 2022
Thanks Kevin ... and thanks reviewers too! |
Follow up to#16629 per slack discussion.
For services and expressions, explicitly use the named argument.