Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Showcase custom validator constraint required option#16770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@norkunas
Copy link
Contributor

Closes#16674

@wouterj
Copy link
Member

wouterj commentedMay 3, 2022•
edited
Loading

Hi! Thank you for your quick response.

I think it's best to create a new example (directly after the first one), e.g. "You can use#[HasNamedArguments] orgetRequiredOptions() to make some constraint options required". This also allows us to add a "versionadded" box:

..versionadded::6.1    The ``#[HasNamedArguments]`` attribute was introduced in Symfony 6.1.

If you agree, are you able to make the changes? :)

@norkunas
Copy link
ContributorAuthor

Hi, will update tomorrow :)

@norkunasnorkunasforce-pushed theconstraint-required-option branch from8939730 todba5d2aCompareMay 4, 2022 03:43
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good, thank you!

gilles-g reacted with thumbs up emojinorkunas reacted with heart emoji
@javiereguiluz
Copy link
Member

Thank you Tomas.

@javiereguiluzjaviereguiluz merged commitebbc61d intosymfony:6.1May 26, 2022
@norkunasnorkunas deleted the constraint-required-option branchMay 26, 2022 17:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

[Validator] Allow creating constraints with required arguments

4 participants

@norkunas@wouterj@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp