Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Finder] Add case insensitive sort#16735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR was squashed before being merged into the 6.2 branch.Discussion----------Update setup.rst ( version 6.2 )Commits-------b7438ff Update setup.rst ( version 6.2 )
* 6.1: Fix: Use correct SF version
* 6.1: [HtmlSanitizer] Fix wrong method name
* 6.1: Add the versionadded directive Add information about DateTimeValueResolver
* 6.1: Fix options path in composer.json
* 6.1: [Frontend] Remove an unused reference
* 6.1: Fix second twig path reference to be consistent with the first reference on security documentation
* 6.1: [HtmlSanitizer] Fix a few typos in the introduction
* 6.1: Remove the deprecated SetUpTearDownTrait feature [PhpUnitBridge] Mention the SetUpTearDownTrait deprecation
* 6.1: Add assets to the documentation add caution to URL-encode special characters in Notifier DSNs [Form][NumberType] Fix constants Fix development testing examples
* 6.1: [Validator] Update validation.rst
* 6.1: [Notifier] Added the Engagespot push notification
* 6.1: Update questionhelper.rst Reword hint about creating config/routes/annotations.yaml as well, when using attributes without doctrine/annotations.
* 6.1: [Doctrine] Add attribute example for Lifecycle Callbacks
* 6.1: Use HTML syntax highlighting Update http_kernel_httpkernelinterface.rst
* 6.1: [Translation] Update locale.rst
* 6.1: Remove deprecated Docs ind "lock"
* 6.1: [Frontend] Update UX package list New features must go on the 6.x branch
…(fabpot)This PR was merged into the 6.2 branch.Discussion----------[Mailer] Add more information about sending email asyncThe example only works as of 6.2 thanks tosymfony/symfony#47075I've written this PR because we keep having issues likesymfony/symfony#44439.So, documenting a bit more how it works internally might help people understand what to do.Commits-------4fbbc16 Add more information about sending email async
* 6.1: [Routing] Fix some internal references links Add links to each Symfony UX component demo Linking to ux.symfony.com
* 6.1: [Messenger] fix broken link to Validator component
* 6.1: Update mercure.rst [HttpKernel] Add UidValueResolver to the list of built-in value resolvers Adding missing `use`s
* 6.1: Be more detailed about coding standards for PHPdoc
* 6.1: Update README.markdown
* 6.1: Adding class constants
* 6.1: [ExpressionLanguage] Feature Null-coalescing operator
javiereguiluz commentedJul 29, 2022
@hmoreau thanks for this contribution! Will you have some time to rebase this PR into 6.2 branch and remove the unrelated commits? Thanks! |
hmoreau commentedJul 29, 2022
Sure, rebase is done |
* 6.1: fix reference markup
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Look alike the rebase does not worked 🤔
hmoreau commentedJul 31, 2022
Here is what I did : Is there something else to do ? |
OskarStark commentedJul 31, 2022
You rebased on 6.2, but the target branch of this PR is |
hmoreau commentedJul 31, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh yes you are right, thank you. |
hmoreau commentedJul 31, 2022
May be it is easier if I make a new PR from scratch? |
javiereguiluz commentedAug 8, 2022
@hmoreau yes please, create a new PR with the right commit with your changes. Thanks! |
Add a new sortByCaseInsensitiveName() method to have case insensitive sorting results.Like the sortByName(), pass true as its argument to use PHP's case insensitive natural sort order algorithm instead.Related to #46126 PRReplacesymfony#16735 PR
This PR was squashed before being merged into the 6.2 branch.Discussion----------[Finder] Add case insensitive sortAdd a new sortByCaseInsensitiveName() method to have case insensitive sorting results.Like the sortByName(), pass true as its argument to use PHP's case insensitive natural sort order algorithm instead.Related tosymfony/symfony#46126 PRReplace#16735 PRCommits-------df9281f [Finder] Add case insensitive sort
Uh oh!
There was an error while loading.Please reload this page.
Add a second argument to
sortByName()method to select between case sensitive and case insensitive sort.