Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Document console completion#16723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.4fromwouterj:console-completion
Apr 21, 2022

Conversation

@wouterj
Copy link
Member

Fixes#15947

I couldn't resist rewriting the Console document a bit, to structure it more like "Usage" and "Implementing a custom command". This created a nice place to talk about setting up completion.

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wouter, thanks for adding the docs of this lovely feature!

@wouterjwouterj merged commitf679e20 intosymfony:5.4Apr 21, 2022
@wouterjwouterj deleted the console-completion branchApril 21, 2022 13:40
@GromNaN
Copy link
Member

Thank you@wouterj. Do you think this page should be updated for 6.1 with the new features: fish completionsymfony/symfony#43641 and configuration in option/argument définitionsymfony/symfony#44948


// complete the input with "Fa" as input
$suggestions = $tester->complete(['Fa']);
$this->assertSame(['Fabien', 'Fabrice'], $suggestions);
Copy link
Member

@GromNaNGromNaNApr 21, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Users will think they need to filter the values themself, while this is done by the completion tool.
I thinkgetCompletionValue usage is rare and reserved to cases when the list of values is too long (like the list of all packages on packagistcomposer/composer#10320 (comment))

@wouterj
Copy link
MemberAuthor

Do you think this page should be updated for 6.1 with the new features

Yes, see#16724 (would be great to get your review there)

wouterj added a commit that referenced this pull requestMay 1, 2022
This PR was merged into the 6.1 branch.Discussion----------[Console] Document completion changes for 6.1Fixes#16623 andfixes#16231Includes#16723 (I'll rebase after that one is merged)Commits-------1878694 Document input definition completion and Fish support
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

+1 more reviewer

@GromNaNGromNaNGromNaN left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Console] Bash completion integration

4 participants

@wouterj@GromNaN@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp