Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Correcting potential typo#1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
riconeitzel wants to merge2 commits intosymfony:masterfromriconeitzel:patch-1
Closed

Correcting potential typo#1667

riconeitzel wants to merge2 commits intosymfony:masterfromriconeitzel:patch-1

Conversation

riconeitzel
Copy link
Contributor

Found in optional step#3: twig vs. php template is inconsistent in body-part

Found in optional step#3: twig vs. php template is inconsistent in body-part
@weaverryan
Copy link
Member

Hi Rico!

You're correct about thestylesheets =>javascripts part, but I'm not sure about the_content =>body part. I don't use the PHP templating engine, but as I understand it,_content is the special slot that is filled in automatically with the child template's content.

Can you remove that change please?

Thanks!

@weaverryan
Copy link
Member

ping@riconeitzel - what do you think about my comment above? Do you agree?

Thanks!

@riconeitzel
Copy link
ContributorAuthor

Hey Ryan,

Didn't have Time to Look into it again. I'm sorry. I'll come back as soon as possible!

Rico

Am 03.10.2012 um 04:53 schrieb Ryan Weavernotifications@github.com:

ping@riconeitzel - what do you think about my comment above? Do you agree?

Thanks!


Reply to this email directly or view it on GitHub.

@weaverryan
Copy link
Member

ping again@riconeitzel :)

Let me know if you have a chance to look into this a bit more! Otherwise, I'll check into it and get it correct!

Cheers!

@riconeitzel
Copy link
ContributorAuthor

Hi Ryan,

sorry for beening that late. you might be right. :-) found that part in PhpEngine. They're requesting stuff from that… perhaps it needs some explanations then?

best,
rico

@weaverryan
Copy link
Member

Hi Rico!

No problem! I've patched your commits into the 2.0 branch at sha:f3cec7f and sha:e4b56d5

About the reference tobody, where exactly were you seeing that?

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@riconeitzel@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp