Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Improve Image constraint invalid mime type message#16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.1frommdoutreluingne:patch-3
Apr 1, 2022
Merged

[Validator] Improve Image constraint invalid mime type message#16663

javiereguiluz merged 1 commit intosymfony:6.1frommdoutreluingne:patch-3
Apr 1, 2022

Conversation

@mdoutreluingne
Copy link
Contributor

@mdoutreluingnemdoutreluingne commentedMar 28, 2022•
edited
Loading

Fixes#16662

Changed the default message in case of incorrect mime type for the image constraint.

From 6.1 we will replaceThis file is not a valid image. with thisThe mime type of the file is invalid ({{ type }}). Allowed mime types are {{ types }}..

@javiereguiluz
Copy link
Member

Thank you Maxime.

@fancyweb
Copy link
Contributor

It's a little bit more complicated than that.

This file is not a valid image. is still the default value but not when the allowed mime types are only a subset ofimage/*, for example:->mimeTypes = ['image/jpeg', 'image/gif'];.

@mdoutreluingne
Copy link
ContributorAuthor

mdoutreluingne commentedApr 4, 2022•
edited
Loading

Sorry for misunderstanding this new change, indeedThis file is not a valid image. is still the default message.

I will correct this as soon as possible.

fancyweb reacted with rocket emoji

javiereguiluz added a commit that referenced this pull requestApr 26, 2022
…age option (mdoutreluingne)This PR was squashed before being merged into the 6.1 branch.Discussion----------[Validator] Fix of the description of the mime type message optionIn this PR, I corrected the mistake I made [here.](#16663)I used the table of parameters of the `File` constraint to explain the different parameters in the `Image` constraint.Can you do a review please?`@fancyweb` ready for review :)Commits-------b557833 [Validator] Fix of the description of the mime type message option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mdoutreluingne@javiereguiluz@fancyweb@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp