Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Update create_form_type_extension.rst#16599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.4fromxabbuh:pr-16506
Mar 15, 2022

Conversation

@xabbuh
Copy link
Member

backport#16506 to4.4

…amkhadiri1989)This PR was submitted for the 6.0 branch but it was merged into the 5.4 branch instead.Discussion----------[Form] Update create_form_type_extension.rstHello,I think the condition `image_url is not null` is not enough as if we create a FileType form field without the `image_property` it causes an error. Adding `image_url is defined` is necessary  because the variable `image_url` is only defined and passed to the view when `image_property` is already defined.<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `6.x` for features of unreleased versions).-->Commits-------85470c5 Update create_form_type_extension.rst
@javiereguiluz
Copy link
Member

Thank you Christian.

@javiereguiluzjaviereguiluz merged commit267d70c intosymfony:4.4Mar 15, 2022
@xabbuhxabbuh deleted the pr-16506 branchMarch 16, 2022 10:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@mdoutreluingnemdoutreluingnemdoutreluingne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@javiereguiluz@mdoutreluingne@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp