Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add documentation for using expressions as service factories#16516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:6.1fromjvasseur:expr-factory
May 1, 2022

Conversation

@jvasseur
Copy link
Contributor

@jvasseurjvasseur commentedFeb 16, 2022•
edited by xabbuh
Loading

@carsonbotcarsonbot added this to the6.1 milestoneFeb 16, 2022
@jvasseurjvasseur changed the titleAdd document for using expressions as service factoriesAdd documentation for using expressions as service factoriesFeb 16, 2022
@javiereguiluz
Copy link
Member

Closing because the related code PR (symfony/symfony#45447) was closed without merging.

@jvasseur
Copy link
ContributorAuthor

The code PR was replaced bysymfony/symfony#45512 which is still opened so this PR could still be relevant.

@xabbuhxabbuh reopened thisMar 24, 2022
@xabbuhxabbuh modified the milestones:6.1,nextMar 24, 2022
@xabbuhxabbuh added the Waiting Code MergeDocs for features pending to be merged labelMar 24, 2022
@nicolas-grekas
Copy link
Member

Code PR has been merged, time to finish this one!

Expressions can be used in ``arguments``, ``properties``, as arguments with
``configurator`` and as arguments to ``calls`` (method calls).

You can also use expressions as factories to create services based on an expression:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about shortening this toYou can also use expressions as service factories:

@nicolas-grekas
Copy link
Member

We should also tell about the args/arg() var/function btw.

@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelMar 28, 2022
@jvasseur
Copy link
ContributorAuthor

I've update the PR to mention thearg function and add theversionadded block.

@wouterjwouterj merged commit2b58adb intosymfony:6.1May 1, 2022
@wouterj
Copy link
Member

Thank you@jvasseur! It's great to retrieve a doc PR for a new code feature :)

Fyi, after the merge I've moved the section to the factories article (and changed the example a bit) in154d667

@jvasseurjvasseur deleted the expr-factory branchMay 2, 2022 12:12
@jvasseur
Copy link
ContributorAuthor

@wouterj thanks for merging, the updated examples looks really good with the associated explanations.

@wkania
Copy link
Contributor

@wouterj154d667 introduced a bug

Found invalid reference "/service_container/expressions" in file       "service_container/factories"

Job "Build the docs" is now broken.

@xabbuh
Copy link
Member

FTR, that was fixed inda91570.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

8 participants

@jvasseur@javiereguiluz@nicolas-grekas@wouterj@wkania@xabbuh@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp