Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DependencyInjection] Fix YAML example in "Defining a Service Locator" section#16458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Service locator is a first constructor argument but is passed as an array of constructor arguments.
Good catch Justas! Thanks and congrats on your first Symfony Docs contribution 🎉 |
@javiereguiluz Will this change be applied to other versions like 5.x, 6.x? |
javiereguiluz commentedFeb 5, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, it should be already in all upper and maintained branches. We "upmerge" all Pull Requests. Cheers! |
Using this example in
v5.3.13
gives this error:I assume this is because
!service_locator
is the first constructor argument but it's passed as an array of constructor arguments, in which case the example is not right.