Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Document the new remember me system#16376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 3 commits intosymfony:5.3fromwouterj:issue-15721/remember-me
Jan 19, 2022

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedJan 7, 2022•
edited
Loading

Fixes#15721,fixes#16149
Replaces#15464, replaces#15893
Ref#15908

In Symfony 5.3, along with the new authentication system, we also somewhat silently introduced a new remember me system. Time to update the remember me docs with all new features :)

This PR also includes 2 commits from open PRs in this repository. We've been very late with this one, and community members have already invested time in contributing necessary changes to the docs before. They deserve the credits :)

@javiereguiluz I'm sorry for not informing you of this work before, I see you just merged a third PR that is replaced by this one.

caliendojulienand others added2 commitsJanuary 7, 2022 17:54
Add some line to the Authenticator to add a RememberMeBadge to the Passport returned
I had to search a while for myself not understanding why I did not have a REMEMBERME cookie when I activated the new system. So maybe handy to add it.
@carsonbotcarsonbot added this to the5.3 milestoneJan 7, 2022
@wouterjwouterj linked an issueJan 7, 2022 that may beclosed by this pull request
@wouterjwouterjforce-pushed theissue-15721/remember-me branch 2 times, most recently from79a417f toc2b7040CompareJanuary 7, 2022 17:05
@wouterjwouterjforce-pushed theissue-15721/remember-me branch fromc2b7040 to5ac2d26CompareJanuary 14, 2022 22:06
@wouterj
Copy link
MemberAuthor

Thanks for the detailed review@gnito-org

After logging in, you can use the security profiler to see if this badge is
present:

..image::/_images/security/profiler-badges.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add analt attribute to improve accessibility?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
..image::/_images/security/profiler-badges.png
..image::/_images/security/profiler-badges.png
:alt: A RememberMeBadge dumped in the security profiler passport column

@javiereguiluz
Copy link
Member

Wouter, thanks a lot for your continuous work on Symfony Docs, especially in security-related docs 🙏

If you agree, I'll let you merge this one because you'll deal withupmerge conflicts better than I'll do. Thanks!

wouterj reacted with thumbs up emoji

@wouterjwouterj merged commit01e7e55 intosymfony:5.3Jan 19, 2022
@wouterj
Copy link
MemberAuthor

Thanks for the review,@javiereguiluz !

@wouterjwouterj deleted the issue-15721/remember-me branchJanuary 19, 2022 14:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

+2 more reviewers

@MarkPedronMarkPedronMarkPedron left review comments

@gnito-orggnito-orggnito-org left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

RememberMeBadge in remember Me Functionality

7 participants

@wouterj@javiereguiluz@MarkPedron@gnito-org@carsonbot@caliendojulien@parijke
[8]ページ先頭
©2009-2025 Movatter.jp