Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Reference the new request_matcher option#16296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@TristanPouliquen
Copy link
Contributor

@derrabus
Copy link
Member

Please target 6.1 here as well.

@xabbuhxabbuh modified the milestones:5.4,6.1,nextDec 26, 2021
@TristanPouliquenTristanPouliquen changed the base branch from5.4 to6.1January 3, 2022 16:51
@wouterjwouterj added the Waiting Code MergeDocs for features pending to be merged labelJan 14, 2022
derrabus added a commit to symfony/symfony that referenced this pull requestJan 31, 2022
…ectly in an ACL definition (TristanPouliquen)This PR was squashed before being merged into the 6.1 branch.Discussion----------[SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition| Q             | A| ------------- | ---| Branch?       | 6.1| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#44103| License       | MIT| Doc PR        |symfony/symfony-docs#16296This PR allows users to directly specify a service reference in the definition of an access control rule. The given service MUST implement the `RequestMatcherInterface`.The goal is to be able to pass custom request matchers, with more complex rules than the standard path, host, ips, ... options to have the same flexibility as the user has in defining his/her firewalls.Commits-------1b5516e [SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition
@derrabus
Copy link
Member

I think, the documentation should show an actual code example of a configured request matcher instead of just mentioning that it is somehow possible to provide your own matcher.

@TristanPouliquen
Copy link
ContributorAuthor

I tried adding one copying from other similar configuration code blocks, is it ok/enough?

@derrabus
Copy link
Member

We usually don't write whole documentation blocks inside aversionadded block. Just document the feature as if it has always existed and add a smallversionadded block blow that new piece of documentation where you tell the reader that this feature has actually been added in 6.1. Once we work on the documentation for Symfony 7, a maintainer can simply drop thatversionadded block without touching the rest of your documentation.

TristanPouliquen reacted with thumbs up emoji

@TristanPouliquenTristanPouliquenforce-pushed theTristanPouliquen-patch-request-matcher branch from99bdf47 to036cb66CompareFebruary 1, 2022 08:58
@TristanPouliquenTristanPouliquenforce-pushed theTristanPouliquen-patch-request-matcher branch fromb06c057 to51181f5CompareFebruary 3, 2022 08:55
@TristanPouliquen
Copy link
ContributorAuthor

@derrabus Is it ok for you to merge now? :)

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I'm powerless on this repository. Someone from the docs team will need to review and merge your PR. 🙃

@TristanPouliquen
Copy link
ContributorAuthor

LGTM, but I'm powerless on this repository. Someone from the docs team will need to review and merge your PR. upside_down_face

Ok, sorry for the ping then, who should I notify to see it merged? :)

..versionadded::6.1

Since Symfony 6.1, an access control rule can also be directly configured by passing a service
implementing `RequestMatcherInterface` through the `request_matcher` option.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

backticks should be doubled

derrabus reacted with thumbs up emoji
@javiereguiluzjaviereguiluz added Security and removed Waiting Code MergeDocs for features pending to be merged labelsJun 28, 2022
@carsonbotcarsonbot changed the titleReference the new request_matcher option[Security] Reference the new request_matcher optionJun 28, 2022
@javiereguiluzjaviereguiluzforce-pushed theTristanPouliquen-patch-request-matcher branch from51181f5 tof0432c4CompareJune 28, 2022 13:48
@javiereguiluzjaviereguiluz merged commit11b0377 intosymfony:6.1Jun 28, 2022
@javiereguiluz
Copy link
Member

Tristan, sorry it took us so long to merge your contribution 🙏 ... and congrats on your first Symfony Docs contribution 🎉

TristanPouliquen reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

+1 more reviewer

@derrabusderrabusderrabus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

7 participants

@TristanPouliquen@derrabus@javiereguiluz@nicolas-grekas@wouterj@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp