Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Security] Reference the new request_matcher option#16296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Security] Reference the new request_matcher option#16296
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedDec 16, 2021
Please target 6.1 here as well. |
…ectly in an ACL definition (TristanPouliquen)This PR was squashed before being merged into the 6.1 branch.Discussion----------[SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#44103| License | MIT| Doc PR |symfony/symfony-docs#16296This PR allows users to directly specify a service reference in the definition of an access control rule. The given service MUST implement the `RequestMatcherInterface`.The goal is to be able to pass custom request matchers, with more complex rules than the standard path, host, ips, ... options to have the same flexibility as the user has in defining his/her firewalls.Commits-------1b5516e [SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition
derrabus commentedJan 31, 2022
I think, the documentation should show an actual code example of a configured request matcher instead of just mentioning that it is somehow possible to provide your own matcher. |
TristanPouliquen commentedJan 31, 2022
I tried adding one copying from other similar configuration code blocks, is it ok/enough? |
derrabus commentedJan 31, 2022
We usually don't write whole documentation blocks inside a |
99bdf47 to036cb66CompareUh oh!
There was an error while loading.Please reload this page.
b06c057 to51181f5CompareTristanPouliquen commentedFeb 16, 2022
@derrabus Is it ok for you to merge now? :) |
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I'm powerless on this repository. Someone from the docs team will need to review and merge your PR. 🙃
TristanPouliquen commentedFeb 16, 2022
Ok, sorry for the ping then, who should I notify to see it merged? :) |
| ..versionadded::6.1 | ||
| Since Symfony 6.1, an access control rule can also be directly configured by passing a service | ||
| implementing `RequestMatcherInterface` through the `request_matcher` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
backticks should be doubled
51181f5 tof0432c4Comparejaviereguiluz commentedJun 28, 2022
Tristan, sorry it took us so long to merge your contribution 🙏 ... and congrats on your first Symfony Docs contribution 🎉 |
Linked tosymfony/symfony#44670