Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Messenger] Autoconfigurable attributes#15990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…assi)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Messenger] Autoconfigurable attributes| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#41106| License | MIT| Doc PR |symfony/symfony-docs#15990Commits-------f27e594 [Messenger] Autoconfigurable attributes
…assi)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Messenger] Autoconfigurable attributes| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Fix #41106| License | MIT| Doc PR |symfony/symfony-docs#15990Commits-------f27e594bad [Messenger] Autoconfigurable attributes
…assi)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Messenger] Autoconfigurable attributes| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Fix #41106| License | MIT| Doc PR |symfony/symfony-docs#15990Commits-------f27e594bad [Messenger] Autoconfigurable attributes
alirezamirsepassi commentedDec 21, 2021
Any update on this PR ?@nicolas-grekas |
94noni commentedDec 28, 2021
Maybe just document that attributes requires php v8 (the feature is on v5.4 thus v8 is not mandatory like v6) |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should target 6.0 to me
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
messenger.rst Outdated
| message interface):: | ||
| create a class using:class:`Symfony\\Component\\Messenger\\Attribute\\AsMessageHandler` | ||
| attribute which has an ``__invoke()`` method that's type-hinted with the | ||
| message class (or a message interface) or you can create a class without the attribute, by implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd remove the mention of the interface
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
wouterj commentedJan 19, 2022
Thank you@alirezamirsepassi for providing docs with your code contributions. I've applied all suggestions made by@nicolas-grekas and added some directives indicating this is a new feature. I did however merge it in 5.4, as that's where this was introduced (which is similar to other PHP attribute we've documented for 5.3/5.4). |
* 5.4: [#15990] Minor changes [Messenger] Autoconfigurable attributes
* 6.0: Removed 5.4 versionadded [#15990] Minor changes [Messenger] Autoconfigurable attributes
Uh oh!
There was an error while loading.Please reload this page.
symfony/symfony#43588