symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Update security.rst#15953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

abdounikarim wants to merge1 commit intosymfony:5.3fromabdounikarim:patch-17

Closed

Update security.rst#15953

abdounikarim wants to merge1 commit intosymfony:5.3fromabdounikarim:patch-17

Conversation

Copy link

Contributor

abdounikarim commentedOct 19, 2021

Hello,

I just updated the link which was wrong.

Update security.rst

1fd0406

Hello,I just updated the link which was wrong.

carsonbot added the Status: Needs Review label

Oct 19, 2021

javiereguiluz reviewed

Oct 20, 2021

View reviewed changes

security.rst

		# config/packages/security.yaml
		security:
		# https://symfony.com/doc/current/security/experimental_authenticators.html
		# https://symfony.com/doc/current/security/authenticator_manager.html

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The old URL just redirects to the main security page ... but the proposed new URL returns a 404 error.@wouterj would it be better to just remove this URL? Thanks.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@javiereguiluz and@wouterj i just updated from here :https://github.com/symfony/recipes/blob/master/symfony/security-bundle/5.3/config/packages/security.yaml

So, we need to update this file too.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are right. I'm proposing to update some links insymfony/recipes#1011

94noni approved these changes

Dec 19, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 19, 2021

Copy link

Member

javiereguiluz commentedDec 29, 2021

@abdounikarim I'm really sorry but I must close this PR without merging because we recently revamped all the security docs (see#15503) and we removed that link, so there's no need to fix it anymore. Thanks!