Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Validator] Some tweaks to CssColor constraint#15906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
welcoMattic commentedOct 8, 2021
Thanks@javiereguiluz to improve the documentation, it's much complete with your additions! |
OskarStark approved these changesOct 8, 2021
fabpot added a commit to symfony/symfony that referenced this pull requestOct 12, 2021
This PR was merged into the 5.4 branch.Discussion----------[Validator] [CssColor] Fixed default behavior| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Following the `@javiereguiluz` PR in docs (symfony/symfony-docs#15906), I figured out I've missed the default behavior of the constraint, which is "all formats are valid if you pass no arguments". It's fixed.I've also replaced an overengineered `array_reduce` with an `implode`.Tests have been updated too.Commits-------cac2ccf Fixed default behavior
symfony-splitter pushed a commit to symfony/validator that referenced this pull requestOct 12, 2021
This PR was merged into the 5.4 branch.Discussion----------[Validator] [CssColor] Fixed default behavior| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Following the `@javiereguiluz` PR in docs (symfony/symfony-docs#15906), I figured out I've missed the default behavior of the constraint, which is "all formats are valid if you pass no arguments". It's fixed.I've also replaced an overengineered `array_reduce` with an `implode`.Tests have been updated too.Commits-------cac2ccfcb5 Fixed default behavior
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the great work made by@welcoMattic in#14965.
It's mostly minor tweaks ... but I also expanded the "basic usage" example to show the case of not adding any parameters to the constraint, which is a common case when you just want to allow any of the valid CSS color formats.