Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Document thehash_property_path option#15872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:6.2fromSeb33300:password-hash-mapping
Oct 23, 2022

Conversation

@Seb33300
Copy link
Contributor

@Seb33300Seb33300 commentedSep 29, 2021•
edited by javiereguiluz
Loading

Documentation forsymfony/symfony#46224

@carsonbotcarsonbot added this to the5.4 milestoneSep 29, 2021
@xabbuhxabbuh added the Waiting Code MergeDocs for features pending to be merged labelOct 1, 2021
@carsonbotcarsonbot modified the milestones:5.4,nextOct 1, 2021
@Seb33300Seb33300force-pushed thepassword-hash-mapping branch 2 times, most recently fromabb2003 to839808fCompareMay 1, 2022 13:52
@Seb33300Seb33300 changed the base branch from5.4 to6.1May 1, 2022 13:53
@Seb33300Seb33300 changed the base branch from6.1 to6.2October 10, 2022 09:59
@Seb33300Seb33300 changed the title[Form] Document thehash_mapping option[Form] Document thehash_property_path optionOct 10, 2022
@Seb33300Seb33300force-pushed thepassword-hash-mapping branch 2 times, most recently fromd8ae8e7 to5950427CompareOctober 10, 2022 11:01
fabpot added a commit to symfony/symfony that referenced this pull requestOct 22, 2022
…e` (Seb33300)This PR was merged into the 6.2 branch.Discussion----------[Form] Add `hash_property_path` option to `PasswordType`| Q             | A| ------------- | ---| Branch?       | 6.2| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#29066| License       | MIT| Doc PR        |symfony/symfony-docs#15872Same as#42883 but using a Form Extension and rebased to 6.1 & tests.This PR adds a new `hash_mapping` option to `PasswordType`.The `hash_mapping` option can be set with a property path where we want to set the hashed password.The `hash_mapping` option can only be used on unmapped fields to minimize plain password leak.Commits-------7065dfe [Form] Add hash_mapping option to PasswordType
@Seb33300
Copy link
ContributorAuthor

This feature is now merged in 6.2 🎉

@javiereguiluz can we merge this PR?

@wouterjwouterj removed the Waiting Code MergeDocs for features pending to be merged labelOct 23, 2022
@wouterjwouterj merged commitbeaa793 intosymfony:6.2Oct 23, 2022
@wouterj
Copy link
Member

Yes we can! Thanks for providing both feature and docs,@Seb33300!

fyi, I've slightly updated the PR while merging (move the versionadded and add some more links).

Seb33300 reacted with heart emoji

@wouterjwouterj modified the milestones:next,6.2Oct 23, 2022
@maxhelias
Copy link
Contributor

I think, we should also explain how to configure it on aRepeatedType

@Seb33300
Copy link
ContributorAuthor

If you want to create a PR to add it to the documentation:

$builder->add('plainPassword', RepeatedType::class, ['type' => PasswordType::class,'first_options'  => ['label' =>'Password','hash_property_path' =>'password'],'second_options' => ['label' =>'Repeat Password'],'mapped' =>false,]);
OskarStark and maxhelias reacted with thumbs up emoji

@Seb33300Seb33300 deleted the password-hash-mapping branchNovember 30, 2022 16:03
@OskarStark
Copy link
Contributor

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

6 participants

@Seb33300@wouterj@maxhelias@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp