[Messenger] document reset_on_message transport option#15796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.4fromlyrixx:messenger-reset

Oct 4, 2021

Merged

[Messenger] document reset_on_message transport option#15796

javiereguiluz merged 1 commit intosymfony:5.4fromlyrixx:messenger-reset

Oct 4, 2021

Conversation

Copy link

Member

lyrixx commentedSep 10, 2021

refssymfony/symfony#41163

carsonbot added Status: Needs Review Messenger labels

Sep 10, 2021

lyrixx mentioned this pull request

Sep 10, 2021

[Mesenger] Add support for reseting container services between 2 messagessymfony/symfony#41163

Merged

fabpot added a commit to symfony/symfony that referenced this pull request

Sep 10, 2021

feature#41163[Mesenger] Add support for reseting container services…

ba7f746

… between 2 messages (lyrixx)This PR was merged into the 5.4 branch.Discussion----------[Mesenger] Add support for reseting container services between 2 messages| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |symfony/symfony-docs#15796Without this patch, services are not resetted. For example MonologFinger Cross handler is never reset nor flushed. So if the firstmessage trigger and "error" level message, all others message will logand overflow the buffer.So, when a transport is **async** (it means it is run in a worker), it's highly preferable to this configuration onUsage with framework:```yamlframework:    messenger:        transports:            async:                dsn: '%env(MESSENGER_TRANSPORT_DSN)%'                reset_on_message: true            failed: 'doctrine://default?queue_name=failed'            sync: 'sync://'```Commits-------488bb88 [Mesenger] Add support for resetting container services after each messenger message.