Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Add section about Service Closures#15731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.4fromHypeMC:service-closure-php-dsl
Mar 9, 2023

Conversation

@HypeMC
Copy link
Member

@HypeMCHypeMC commentedAug 19, 2021•
edited
Loading

Documents service closures added insymfony/symfony#21770 andsymfony/symfony#41176, and theservice_closure() PHP-DSL function added insymfony/symfony#42625 .

@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch 4 times, most recently from562d799 to1dea8a0CompareAugust 20, 2021 01:09
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestAug 20, 2021
…-DSL (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Add service_closure() to the PHP-DSL| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#15730 andsymfony/symfony-docs#15731Adds a `service_closure()` function to the PHP-DSL.Commits-------f333fa0 [DI] Add service_closure() to the PHP-DSL
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestAug 20, 2021
…-DSL (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Add service_closure() to the PHP-DSL| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#15730 andsymfony/symfony-docs#15731Adds a `service_closure()` function to the PHP-DSL.Commits-------f333fa0e05 [DI] Add service_closure() to the PHP-DSL
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch from1dea8a0 to822bcecCompareAugust 20, 2021 16:08
@javiereguiluzjaviereguiluz added this to the5.4 milestoneJun 10, 2022
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch from822bcec to1e40081CompareOctober 1, 2022 14:25
Comment on lines 96 to 97
Using Service Closures in Compiler Passes
-----------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Using Service Closures in CompilerPasses
-----------------------------------------
Using Service Closures in CompilerPass
---------------------------------------

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe even use Service Closure (singular) in the headline?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about "Using a Service Closures in a Compiler Pass"?

OskarStark reacted with thumbs up emoji
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch 2 times, most recently from005216a to8ab82c2CompareOctober 1, 2022 18:52
@OskarStarkOskarStark changed the title[DependencyInjection] Document PHP-DSL service_closure() function[DependencyInjection] Document PHP-DSLservice_closure() functionOct 2, 2022
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch 4 times, most recently fromab6d0d0 tob69cdaaCompareMarch 2, 2023 08:47
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch fromb69cdaa to1958c06CompareMarch 2, 2023 11:58
@HypeMCHypeMC changed the title[DependencyInjection] Document PHP-DSLservice_closure() function[DependencyInjection] Add section about Service ClosuresMar 2, 2023
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch fromf391a2c to28f9b55CompareMarch 9, 2023 04:33
@HypeMCHypeMCforce-pushed theservice-closure-php-dsl branch from28f9b55 tof2b2fdbCompareMarch 9, 2023 04:35
@OskarStark
Copy link
Contributor

Thank you@HypeMC.

HypeMC and jdreesen reacted with hooray emoji

@OskarStarkOskarStark merged commitdefdea4 intosymfony:5.4Mar 9, 2023
@HypeMCHypeMC deleted the service-closure-php-dsl branchMarch 9, 2023 08:25
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good job with this PR, I've left a small comment, sorry for the delay.

OskarStark added a commit to OskarStark/symfony-docs that referenced this pull requestMar 11, 2023
OskarStark added a commit that referenced this pull requestMay 11, 2023
This PR was squashed before being merged into the 5.4 branch.Discussion----------Be consistent in code examplesFollows#15731 (comment)cc `@HeahDude`Commits-------2426ce4 Be consistent in code examples
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@javiereguiluzjaviereguiluzAwaiting requested review from javiereguiluz

+2 more reviewers

@jdreesenjdreesenjdreesen left review comments

@HeahDudeHeahDudeHeahDude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@HypeMC@OskarStark@jdreesen@HeahDude@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp