Deprecate getDoctrine() and dispatchMessage() shortcuts#15607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.4fromjaviereguiluz:fix_15605

Aug 10, 2021

Merged

Deprecate getDoctrine() and dispatchMessage() shortcuts#15607

javiereguiluz merged 1 commit intosymfony:5.4fromjaviereguiluz:fix_15605

Aug 10, 2021

Conversation

Copy link

Member

javiereguiluz commentedAug 9, 2021

Fixes#15605.

javiereguiluz added this to the5.4 milestone

Aug 9, 2021

javiereguiluz requested a review fromxabbuh as acode owner

August 9, 2021 11:01

carsonbot added the Status: Needs Review label

Aug 9, 2021

javiereguiluz mentioned this pull request

Aug 9, 2021

Deprecate the get() and has() shortcuts of AbstractController#15609

Merged

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request

Aug 9, 2021

minorsymfony#15609Deprecate the get() and has() shortcuts of Abstra…

3fa34a9

…ctController (javiereguiluz)This PR was merged into the 5.4 branch.Discussion----------Deprecate the get() and has() shortcuts of AbstractControllerFixessymfony#15606.We've been promoting service injection for long, so there weren't many `get()` occurrences to fix and I couldn't find any `has()` occurrence from AbstractController.This PR leaves a `get()` usage on purpose in the `doctrine.rst` article because it was removed in another PR:symfony#15607.Commits-------901535c Deprecate the get() and has() shortcuts of AbstractController