Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Fixing missingarguments#15462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ktherage wants to merge1 commit intosymfony:5.3fromktherage:patch-1

Conversation

@ktherage
Copy link
Contributor

This PR aim to fix a missingarguments key in service configuration example.

@OskarStarkOskarStark requested a review fromwouterjJune 23, 2021 18:40
@carsonbotcarsonbot changed the titleFixing missingarguments[DependencyInjection] Fixing missingargumentsJun 25, 2021
@javiereguiluz
Copy link
Member

Thanks Kevin ... just asking: do you propose this change because the syntax is wrong or because you prefer the syntax with thearguments word in it? I'm asking because not addingarguments is valid ... I've just checked some Symfony apps of mine and sometimes I don't addarguments in some service configuration. Maybe I'm missing something here?

@HeahDude
Copy link
Contributor

arguments can be omitted when it's the only key to be defined.
Refsymfony/symfony#21313 and#7441.
I would close this one.

ktherage reacted with thumbs up emoji

@javiereguiluz
Copy link
Member

Thanks a lot Jules 🙏 That's the confirmation that we needed here. Let's close then. Thanks!

@ktheragektherage deleted the patch-1 branchAugust 18, 2021 13:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjAwaiting requested review from wouterj

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ktherage@javiereguiluz@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp