Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Config] Added caution notice about nested bundle configs#15300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for this.
Uh oh!
There was an error while loading.Please reload this page.
d25965a to3cceddcCompareMember
javiereguiluz commentedApr 30, 2021
Thank you Alexander. |
derrabus added a commit to symfony/symfony that referenced this pull requestMay 2, 2021
…a-menshchikov)This PR was merged into the 5.3-dev branch.Discussion----------[Config] More accurate message on invalid config builder| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Throw exception when trying to autowire nested bundle config instead of ConfigBuilder (related Doc PRsymfony/symfony-docs#15300).Also renamed test class AcmeConfigBuilder to AcmeConfig according config builders auto naming.Inspired by a chat with `@Nyholm`Commits-------0501ecc More accurate message on invalid config builder
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a chat with@Nyholm