Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Notifier] Documentation for Microsoft Teams Options#15288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
KamilKubicki commentedApr 23, 2021
Please review as complementary commit to: [Notifier] Add docs for Microsoft Teams Options#15232 |
notifier/chatters.rst Outdated
| :align:center | ||
| Adding Interactions to a Microsoft Teams Message | ||
| ----------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There should be the same length.
@OskarStark, shouldn't DOCtor find this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@OskarStark, shouldn't DOCtor find this?
AFAIK there is no such rule, because Sphinx allows this 🤔
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
Could we add more "real" values in the examples?
| use Symfony\Component\Notifier\Bridge\MicrosoftTeams\Section\Section; | ||
| use Symfony\Component\Notifier\Message\ChatMessage; | ||
| $chatMessage = new ChatMessage(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should the first argument really be empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
new ChatMessage('') requires a subject string argument, if this argument is given, then->text('Text') should be skipped while settingnew MicrosoftTeamsOptions(). In otherw wordsnew ChatMessage('') and->text('Text') are equivalents. In my example I used second one to set the text.
notifier/chatters.rst Outdated
| $input = new TextInput(); | ||
| $input->id('input_title'); | ||
| $input->isMultiline(true)->maxLength(5)->title('Input Title'); | ||
| $input->isMultiline(true)->maxLength(5)->title('In few words, why would you like to participate?'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $input->isMultiline(true)->maxLength(5)->title('In few words, why would you like to participate?'); | |
| $input->isMultiline(true)->maxLength(5)->title('Inafew words, why would you like to participate?'); |
notifier/chatters.rst Outdated
| (new Section()) | ||
| ->title('Section - name') | ||
| ->section((new Section()) | ||
| ->title('Talk about Symfony 5.x - would you like to join? Please give a shout!') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ->title('Talk about Symfony 5.x - would you like to join? Please give a shout!') | |
| ->title('Talk about Symfony 5.3 - would you like to join? Please give a shout!') |
notifier/chatters.rst Outdated
| ->title('Talk about Symfony 5.x - would you like to join? Please give a shout!') | ||
| ->fact((new Fact()) | ||
| ->name('Presenter') | ||
| ->value('John Doe') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ->value('John Doe') | |
| ->value('Fabien Potencier') |
KamilKubicki commentedMay 18, 2021
Hi@Nyholm, related issue from@OskarStark was already merged - [Notifier] Microsoft Teams: JSON structure error fix for simple message #40834. Should you require any action from my side for this documentation or we can consider that it is ready for merge? |
OskarStark commentedMay 18, 2021
It's done but we can merge this for 5.4 when the feature got merged |
…karStark)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Notifier] Add options to Microsoft Teams notifier| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Follows#39007| License | MIT| Doc PR |symfony/symfony-docs#15288### After rework:<img width="374" alt="CleanShot 2021-04-15 at 09 40 45@2x" src="https://user-images.githubusercontent.com/995707/114832421-c04c9400-9dce-11eb-8135-77ee1fb21314.png">Commits-------d039ce7 [Notifier] Add options to Microsoft Teams notifier
c192875 to3c98ba8Comparejaviereguiluz commentedJul 27, 2021
Thanks Kamil for this nice contribution 🎉 |
Uh oh!
There was an error while loading.Please reload this page.
Docs forsymfony/symfony#40738
Replaces#15232