Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Document console cursor#15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.2fromnoniagriconomie:console-cursor
Jun 17, 2021

Conversation

noniagriconomie
Copy link
Contributor

fixes#13529
featuresymfony/symfony#27444

ping@wouterj I've seen your slack recently and wanted to give it a try as I will use the feature very soon :)
feel free to comment, specialy if I need to document all the cursor features or not

text and image taken from the feature PR description
inspired byhttps://symfony.com/doc/current/components/console/helpers/progressbar.html

@Nyholm
Copy link
Member

(The “code block” ci job does not support adding new files. I’ll fix that in a separate pr)

@Nyholm
Copy link
Member

The CI job is updated.

Regarding your PR: Do we need to create a new page or is there an existing page we can add this content to?

@noniagriconomie
Copy link
ContributorAuthor

@Nyholm Thank you for the CI
for your second point, I personally checked thehttps://symfony.com/doc/current/components/console.html#learn-more list and found it will be great to add it here

If you or other found a better place,, I will be pleased to swap the code of course :)

@Nyholm
Copy link
Member

Oh. Hmm.. I see.

There is a greater plan to make everything under one document. I'll wait for input from the docs team.

Btw, test retrigger the CI with:

git commit --allow-empty  -m "Trigger CI"git push
noniagriconomie reacted with thumbs up emoji

@noniagriconomienoniagriconomie changed the titleDocument console cursor[Console] Document console cursorApr 22, 2021
@Nyholm
Copy link
Member

Cool. Another CI error. We dont support non-rst files =)

I should filter out these too.

@Nyholm
Copy link
Member

May I bother you to trigger the CI again?

@noniagriconomie
Copy link
ContributorAuthor

@Nyholm here you are :)
feel free to edit/commit on this PR if you can

@Nyholm
Copy link
Member

Wohoo. The CI is green. Thank you for helping me.

I am also happy with the content of this PR.
👍🏽

noniagriconomie reacted with hooray emoji

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for starting this@noniagriconomie!

I think we should document all available methods. I've made some suggestions on how to do this somewhat briefly below (to avoid long boring listings).

I'm fine with keeping it in a separate document. It seems the most logical from the current Console documentation structure. We can always revisit this when we start working on the Console docs

@carsonbotcarsonbot changed the title[Console] Document console cursorDocument console cursorApr 24, 2021
@wouterjwouterj added this to the5.2 milestoneApr 24, 2021
@carsonbotcarsonbot changed the titleDocument console cursor[Console] Document console cursorApr 24, 2021
@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedApr 27, 2021•
edited
Loading

@wouterj many thanks for the reviews, I've tried to address them all
status: review

edit: I do not understand theCI sphinx error

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 2 minor comments left, ready to merge imho :)

Nyholm reacted with thumbs up emoji
Comment on lines +72 to +75
// move the cursor to a specific position from its current position
$cursor->moveToPosition(7, 11);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I haven't used this feature, but I think we have to clearify this a bit. This means 7 lines down, and 11 columns to the right? And I can use negative numbers to achieve the opposite?

Or does this expect a coordinate?

Copy link
ContributorAuthor

@noniagriconomienoniagriconomieMay 14, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@wouterj it means 7 cols right, 11 rows down from console init cursor
the cursor always moves position from this 0:0 position, thus need an x:y (here positive values) from the init yes

@noniagriconomie
Copy link
ContributorAuthor

friendly ping@OskarStark I may hope you are the best to ping here related to the error I have:

Warning: ] Found "1" invalid file!                                              Error: Please do not use ".. code-block:: php", use "::" instead.

I've check other code bloc and for me it is "correct" here, or what am I doing wrong? many thanks :)

@wouterjwouterj changed the base branch from5.4 to5.2June 17, 2021 11:02
@wouterjwouterj requested a review fromxabbuh as acode ownerJune 17, 2021 11:02
wouterj added a commit that referenced this pull requestJun 17, 2021
@wouterjwouterj merged commitfb749b5 intosymfony:5.2Jun 17, 2021
@wouterj
Copy link
Member

Thank you@noniagriconomie ! I'm sorry this took a while...

The build error appears to be a bug in DOCtor (@OskarStark), I've silenced the rule for now (along with some minor changes) in7565926

noniagriconomie reacted with thumbs up emoji

@noniagriconomienoniagriconomie deleted the console-cursor branchJune 17, 2021 11:55
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJun 17, 2021
* upstream/5.2:  [symfony#15270] Minor fixes  [Console] Document console cursor
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJun 17, 2021
* 5.2:  Minor tweaks  Adds a heading for stampede prevention so I'm able to reference this section easily  [symfony#15270] Minor fixes  [Console] Document console cursor  Update routing.rst
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJun 17, 2021
* 5.3:  Minor tweaks  Adds a heading for stampede prevention so I'm able to reference this section easily  [symfony#15270] Minor fixes  [Console] Document console cursor  [Security] changed interface name to the correct one  [Form] Fixed a code example related to CSRF  Update routing.rst  Typo
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJun 17, 2021
* 5.4:  Minor tweaks  Adds a heading for stampede prevention so I'm able to reference this section easily  [symfony#15270] Minor fixes  [Console] Document console cursor  [Security] changed interface name to the correct one  [Form] Fixed a code example related to CSRF  Update routing.rst  Typo
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@wouterjwouterjwouterj approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Console] Add Cursor class to control the cursor in the terminal
4 participants
@noniagriconomie@Nyholm@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp