Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Start using ConfigBuilder#15264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The new config builder looks much better to me than the old plain PHP arrays. Love it! Thanks Tobias.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
javiereguiluz commentedApr 21, 2021
It's merged! 🎉 I couldn't like this more 😍 It's so great! Thanks Tobias. |
Nyholm commentedApr 21, 2021
Thank you for merging |
This PR was squashed before being merged into the 5.3-dev branch.Discussion----------[Config] Use plural name on array values| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR | Related:symfony/symfony-docs#15264If we have a PrototypedArrayNode and the prototype is does not have a key (`->useAttributeAsKey('name')`). Then we know for sure that the value should be an array.See this example from `$framework->assets()````diff /**+ *@param list<mixed> *@return $this */- public function baseUrl($value): self+ public function baseUrls(array $value): self { $this->baseUrls = $value; return $this; }```Commits-------f564a7a [Config] Use plural name on array values
I start with 5 documents to see how it feels.