Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Start using ConfigBuilder#15264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:5.xfromNyholm:config.builder
Apr 21, 2021
Merged

Conversation

@Nyholm
Copy link
Member

I start with 5 documents to see how it feels.

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The new config builder looks much better to me than the old plain PHP arrays. Love it! Thanks Tobias.

@javiereguiluzjaviereguiluz added this to the5.3 milestoneApr 21, 2021
@javiereguiluz
Copy link
Member

It's merged! 🎉 I couldn't like this more 😍 It's so great! Thanks Tobias.

OskarStark reacted with rocket emoji

@javiereguiluzjaviereguiluz merged commit4fa5ab4 intosymfony:5.xApr 21, 2021
@Nyholm
Copy link
MemberAuthor

Thank you for merging

@NyholmNyholm deleted the config.builder branchApril 21, 2021 07:39
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestApr 21, 2021
This PR was squashed before being merged into the 5.3-dev branch.Discussion----------[Config] Use plural name on array values| Q             | A| ------------- | ---| Branch?       | 5.x| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        | Related:symfony/symfony-docs#15264If we have a PrototypedArrayNode and the prototype is does not have a key (`->useAttributeAsKey('name')`). Then we know for sure that the value should be an array.See this example from `$framework->assets()````diff    /**+    *@param list<mixed>     *@return $this     */-   public function baseUrl($value): self+   public function baseUrls(array $value): self    {        $this->baseUrls = $value;        return $this;    }```Commits-------f564a7a [Config] Use plural name on array values
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Nyholm@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp