Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add docs for Microsoft Teams Options#15232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedApr 13, 2021•
edited
Loading

@OskarStarkOskarStark self-assigned thisApr 13, 2021
@carsonbotcarsonbot changed the titleAdd docs for Microsoft Teams Options[Notifier] Add docs for Microsoft Teams OptionsApr 13, 2021
@OskarStarkOskarStark added the Waiting Code MergeDocs for features pending to be merged labelApr 13, 2021
@carsonbotcarsonbot added this to thenext milestoneApr 13, 2021
@javiereguiluz
Copy link
Member

Thanks for this contribution!

However, I find the name "options" confusing. In the docs that you linked, they call them "fields" (and sometimes, "properties"). I find it confusing because things like "title" or "bgColor" doesn't seem options, but data/metadata. An option would be used to decide if the title is displayed or not, but the title content is not an option, right?

Maybe I'm missing things because I don't use Microsoft Teams.

@OskarStark
Copy link
ContributorAuthor

In notifier we use options term in general 🧐

@javiereguiluz
Copy link
Member

Oskar, I wasn't aware of that. Then, let's keep it. Better be consistent at least. Thanks!

@OskarStark
Copy link
ContributorAuthor

Oskar, I wasn't aware of that. Then, let's keep it. Better be consistent at least. Thanks!

No problem 😃

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice contribution! Thanks Oskar.

@OskarStarkOskarStarkforce-pushed thefeature/ms-teams-options branch 3 times, most recently from7d1d15d to9557e5fCompareApril 17, 2021 06:39
@OskarStark
Copy link
ContributorAuthor

Superseeded by#15288

@OskarStarkOskarStark deleted the feature/ms-teams-options branchApril 26, 2021 07:55
javiereguiluz added a commit that referenced this pull requestJul 27, 2021
…milKubicki)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Notifier] Documentation for Microsoft Teams OptionsDocs forsymfony/symfony#40738Replaces#15232Commits-------3c98ba8 [Notifier] Documentation for Microsoft Teams Options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

@OskarStarkOskarStark

Labels

NotifierStatus: ReviewedWaiting Code MergeDocs for features pending to be merged

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

3 participants

@OskarStark@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp