[Uid] Document the methods to generate and inspect UIDs#15209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.xfromjaviereguiluz:fix_15032

Apr 20, 2021

Merged

[Uid] Document the methods to generate and inspect UIDs#15209

javiereguiluz merged 1 commit intosymfony:5.xfromjaviereguiluz:fix_15032

Apr 20, 2021

Conversation

Copy link

Member

javiereguiluz commentedApr 9, 2021

Fixes#15032.

javiereguiluz added the Uid label

Apr 9, 2021

javiereguiluz added this to the5.3 milestone

Apr 9, 2021

carsonbot added the Status: Needs Review label

Apr 9, 2021

wouterj approved these changes

Apr 9, 2021

View reviewed changes

components/uid.rst OutdatedShow resolvedHide resolved

components/uid.rst

Comment on lines +385 to +393

		services:
		Symfony\Component\Uid\Command\GenerateUlidCommand:~
		Symfony\Component\Uid\Command\GenerateUuidCommand:~
		Symfony\Component\Uid\Command\InspectUlidCommand:~
		Symfony\Component\Uid\Command\InspectUuidCommand:~

Copy link

Member

wouterjApr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I understand why they are optional, but this seems like a really non-DX friendly feature this way.@fancyweb @nicolas-grekas is there a particular reason not to add a config option for this?