Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Docs for Slack options field() method#15198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:5.2fromOskarStark:feature/13398
Apr 15, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedApr 7, 2021•
edited
Loading

Closes#13398

Example and image taken fromsymfony/symfony#36154 (comment)

cc@birkof as you provided this feature

@OskarStarkOskarStark added this to the5.2 milestoneApr 7, 2021
@OskarStarkOskarStark requested a review fromwouterjApril 7, 2021 13:19
@carsonbotcarsonbot changed the titleDocs for Slack options field() method[Notifier] Docs for Slack options field() methodApr 7, 2021
@OskarStarkOskarStark requested a review fromfabpotApril 7, 2021 13:22

The result will be something like:

..image::/_images/notifier/slack/field-method.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure an image is needed here ... the feature is easy to understand ... and this image will be outdated as soon as Slack makes any visual change in their app (which is common).

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree but decided to add it because its not clear "how" the are displayed, because you add them in procedural way but its rendered like "table"

If you want, feel free to remove it while merging

@OskarStark
Copy link
ContributorAuthor

Rebased

@javiereguiluz
Copy link
Member

Thank you Oskar.

@javiereguiluzjaviereguiluz merged commit7bfd2ef intosymfony:5.2Apr 15, 2021
@OskarStarkOskarStark deleted the feature/13398 branchDecember 7, 2024 11:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@wouterjwouterjAwaiting requested review from wouterj

@fabpotfabpotAwaiting requested review from fabpot

Assignees
No one assigned
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

3 participants
@OskarStark@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp