Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add normalizer option to Unique constraint#15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

henry2778
Copy link
Contributor

@henry2778henry2778 commentedMar 19, 2021•
edited
Loading

Hello. Documenting the featuresymfony/symfony#38488 aboutnormalizer option for Unique constraint.

  1. Updated the intro paragraph mentioning the strict comparison
  2. Added normalizer to the option list
  3. Added normalizer option description. There is a include file for that, but since the description is slightly different, I decided not use it.

Thanks!

:phpfunction:`trim` PHP function to each element of the collection in order to ignore leading and trailing
whitespace during validation.

.. _`PHP callable`: https://www.php.net/callable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please move this to the bottom of the file

For example, you may want to pass the ``'trim'`` string to apply the
:phpfunction:`trim` PHP function to each element of the collection in order to ignore leading and trailing
whitespace during validation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a versionadded directive

The ''normalizer'' option was introduced in Symfony 5.3.

' is a backtick, I am currently on a phone 📱😄

@@ -107,8 +109,8 @@ Options

.. include:: /reference/constraints/_groups-option.rst.inc

message
~~~~~~~
``message``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this the case for all constraints? If yes this should be fixed in the lowest maintained branch (4.4) for the constraints.

We would be glad to receive such a PR from your side, but if you don't have time, no worries.

This should not be fixed in this PR, so please revert this line, thanks

henry2778 reacted with thumbs up emoji
@OskarStarkOskarStark added this to the5.3 milestoneMar 21, 2021
@henry2778
Copy link
ContributorAuthor

@OskarStark thanks. fixed

@javiereguiluzjaviereguiluzforce-pushed thefeature/unique-normalizer-option branch from227c9a1 to92072d9CompareMarch 27, 2021 19:00
@javiereguiluzjaviereguiluz merged commitb4d93f3 intosymfony:5.xMar 27, 2021
@javiereguiluz
Copy link
Member

Andrii, thanks for this nice contribution!

henry2778 reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

6 participants
@henry2778@javiereguiluz@OskarStark@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp