Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Configuration of the message_bus to use#15045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.2fromt-richard:mailer-message-bus
Mar 11, 2021

Conversation

t-richard
Copy link
Contributor

@carsonbot
Copy link
Collaborator

Hey!

Haha, I was thinking of doing this exact same thing. =)

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update thePR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@carsonbotcarsonbot added this to the5.1 milestoneFeb 28, 2021
@t-richardt-richard changed the base branch from5.1 to5.2February 28, 2021 22:29
@javiereguiluzjaviereguiluz modified the milestones:5.1,5.2Mar 1, 2021
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I though this was document already.

Well done!

@t-richard
Copy link
ContributorAuthor

I'm currently going through the5.1 milestone in the issues and trying to document missing features listed there, that's how I caught it 🙂

@Nyholm
Copy link
Member

Nice. You are the best!

That is very appreciated and a great way learn about (new) features.

t-richard reacted with heart emoji

@t-richard
Copy link
ContributorAuthor

Actually got the idea from yousome months ago 😉

And had some time lately to contribute !

Nyholm reacted with laugh emojiNyholm reacted with heart emoji

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add missing version added directive, thanks

@OskarStark
Copy link
Contributor

Thank you Thibault.

t-richard reacted with heart emoji

@OskarStarkOskarStark merged commitbbadeae intosymfony:5.2Mar 11, 2021
@t-richardt-richard deleted the mailer-message-bus branchMarch 11, 2021 15:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@NyholmNyholmNyholm approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

6 participants
@t-richard@carsonbot@Nyholm@OskarStark@maxhelias@javiereguiluz
[8]ページ先頭
©2009-2025 Movatter.jp