As Symfony 3.4 is not currently supported (security fixes only) I would like to propose to start promoting the new bundle directory structure (compatible since 4.4) consistent with the project one.

What do you think?

Fix:#12156
PR:symfony/symfony#32845

carsonbot added the Status: Needs Review label

Feb 17, 2021

yceruto force-pushed thebundles_structure branch 2 times, most recently froma446761 to7ae696fCompare

February 17, 2021 14:44

Copy link

Member

javiereguiluz commentedFeb 17, 2021

What's our official recommendation for existing third-party bundles that no longer support 3.4. Do we encourage them to upgrade their structure or it's better to use this only in brand-new bundles?

Related to the previous question, even if we don't recommend to change the structure for existing bundles, can you think of any problem if they do? Thanks!

yceruto force-pushed thebundles_structure branch from7ae696f to0b6e53cCompare

February 17, 2021 14:57

Nyholm approved these changes

Feb 17, 2021

View reviewed changes

Copy link

Member

Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

Do we encourage them to upgrade their structure or it's better to use this only in brand-new bundles?

They can do whatever they want. Im not sure we should give an opinon. Both work and we find the new structure to be better. Where "better" means, more "PHP" and less "symfony specific"

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 17, 2021

ogizanagi reviewed

Feb 17, 2021

View reviewed changes

bundles/best_practices.rst


		class AcmeBlogBundle extends Bundle
		{
		public function getPath(): string

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

BTW, should we deprecate not overriding this method, so that we can make this the default in sf 6.0?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was wondering the same thing, I think we can do that when we decide to start depreciating the old structure.

OskarStark added this to the4.4 milestone

Feb 17, 2021

OskarStark approved these changes

Feb 17, 2021

View reviewed changes

Copy link

Contributor

OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should target 4.4 👍

Copy link

MemberAuthor

yceruto commentedFeb 17, 2021

What's our official recommendation for existing third-party bundles that no longer support 3.4. Do we encourage them to upgrade their structure or it's better to use this only in brand-new bundles?

As long as the old structure is kept alive, I don't think we should encourage upgrading, at least not now. Maybe when we start deprecating the old structure.

Related to the previous question, even if we don't recommend to change the structure for existing bundles, can you think of any problem if they do? Thanks!

As long as the bundle is strictly compatible with Sf >= 4.4 shouldn't be a problem 🤞

stof reviewed

Feb 17, 2021

View reviewed changes

bundles/best_practices.rst OutdatedShow resolvedHide resolved

Copy link

Member

maybe the doc should have a note saying that this structure can be used only when requiringsymfony/http-kernel 4.4+ only, to avoid issues with bundle migrating to it (due to reading the new doc) without changing their min version.