Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add warning about removed services#14819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:4.4fromalexislefebvre:add-tip-about-removed-servicesJan 15, 2021
Merged
Add warning about removed services#14819
javiereguiluz merged 1 commit intosymfony:4.4fromalexislefebvre:add-tip-about-removed-servicesJan 15, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
OskarStark approved these changesJan 12, 2021
Uh oh!
There was an error while loading.Please reload this page.
9bd3b60 toe6a6c33CompareMember
javiereguiluz commentedJan 15, 2021
Thank you Alexis! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I was confused by the fact that the documentation explains:
and the fact that the special container doesn't give access to the removed service.
So I added a tip in the documentation, taking inspiration from a Symfony article:
Source:https://symfony.com/blog/new-in-symfony-4-1-simpler-service-testing
This is also consistent with the error message from Symfony:https://github.com/symfony/symfony/blob/3ffe5573e9dd045e157c6f17358c700fceae3feb/src/Symfony/Component/DependencyInjection/Container.php#L275
See also#12647 andsymfony/symfony#30104