Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Update access_control.rst#14816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:4.4fromBooleanType:patch-4
Jan 12, 2021

Conversation

BooleanType
Copy link
Contributor

@BooleanTypeBooleanType commentedJan 10, 2021•
edited by OskarStark
Loading

IMHO, rule 1 should be applied instead of rule 2, because URI and IP match is enough for rule 1.

@xabbuh
Copy link
Member

I think a better solution would be to reorder the rules instead.

@xabbuhxabbuh added this to the4.4 milestoneJan 11, 2021
@BooleanType
Copy link
ContributorAuthor

I think a better solution would be to reorder the rules instead.

Thought about it too :) Done.

xabbuh reacted with thumbs up emoji

@carsonbotcarsonbot changed the titleUpdate access_control.rst[Security] Update access_control.rstJan 12, 2021
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great apart from my little comment!

@OskarStark
Copy link
Contributor

Thank you@BooleanType.

@OskarStarkOskarStark merged commitf50119c intosymfony:4.4Jan 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

@HeahDudeHeahDudeAwaiting requested review from HeahDude

Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

4 participants
@BooleanType@xabbuh@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp