Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[String] Feature 39178#14776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
[String] Feature 39178#14776
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestJan 26, 2021
… symbolsMap (jontjs)This PR was merged into the 5.3-dev branch.Discussion----------[String] Made AsciiSlugger fallback to parent locale's symbolsMap| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#39178| License | MIT| Doc PR |symfony/symfony-docs#14776The Slugger already performed a fallback from (e.g.) 'en_GB' to (e.g.) 'en' for the transliterator, this PR adds similar behaviour for the symbols map.Commits-------916a8cf [String] Make AsciiSlugger fallback to parent locale's symbolsMap
Documentation update for [String] Feature 39178 "AsciiSlugger's symbolsMap should apply to all locales for a language".
Member
javiereguiluz commentedJan 29, 2021
Jon, thanks a lot for contributing this feature and the docs for it. Congrats on your first Symfony Docs contribution too 🎉 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Docs forsymfony/symfony#39178
Documentation update for [String] Feature 39178 "AsciiSlugger's symbolsMap should apply to all locales for a language".