Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Rewording#14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.4fromThomasLandauer:patch-13
Dec 30, 2020
Merged

[Form] Rewording#14762

javiereguiluz merged 1 commit intosymfony:4.4fromThomasLandauer:patch-13
Dec 30, 2020

Conversation

ThomasLandauer
Copy link
Contributor

As a separate PR, as recommended by#13450 (comment)

Note:addTagForm was the wrong function name, it's now calledaddFormToCollection()

As a separate PR, as recommended bysymfony#13450 (comment)Note: `addTagForm` was the wrong function name, it's now called `addFormToCollection()`
@carsonbotcarsonbot added this to the4.4 milestoneDec 30, 2020
@carsonbotcarsonbot changed the titleRewording[Form] RewordingDec 30, 2020
@javiereguiluzjaviereguiluz merged commit0e1fc2f intosymfony:4.4Dec 30, 2020
@javiereguiluz
Copy link
Member

Thomas, we agree on removing this phrase because it doesn't say much ->"The actual code needed to make this all work can vary quite a bit, but here's one example:"

However, we disagree with the removal of the first phrase:"TheaddFormToCollection() function's job will be to use thedata-prototype attribute to dynamically add a new form when this link is clicked.". That's the most crucial phrase to understand what's that "strange"data-prototype attribute, so we left it. However, we included your minor tweaks to the original text.

Thanks!

@ThomasLandauerThomasLandauer deleted the patch-13 branchDecember 30, 2020 15:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

3 participants
@ThomasLandauer@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp