Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Cache] Add TLS scheme for Redis connection#14728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… (misaert)This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.Discussion----------[Cache] Fix Redis TLS scheme `rediss` for Redis connection| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |symfony/symfony-docs#14728Like#35503 on Symfony Messenger, this will enable TLS support for Redis adapter.The implementation just prefix the host with `tls://` as described here:https://github.com/phpredis/phpredis#connect-openI don't know how to test it because I guess I need a TLS Redis in `src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php`.Commits-------3288897 [Cache] Fix Redis TLS scheme `rediss` for Redis connection
nicolas-grekas commentedFeb 22, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is that correct? Isn't TLS enabled by using the |
misaert commentedFeb 22, 2021
No, it is not correct because the implementation has changed over time. I take care of changing this PR to correspond with the choosen implementation 😉 |
misaert commentedFeb 22, 2021
Changed. Do I have to change the destination of the branch to |
nicolas-grekas commentedFeb 22, 2021
Yes please, and rebase on 4.4 before. |
misaert commentedFeb 22, 2021
Done. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
wouterj commentedApr 7, 2021
Hi@misaert! I'm not sure why this PR has been open for quite a while after the code merge. All seems perfect. Thanks for taking care of updating the docs! |
* 4.4: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated [#14728] Be explicit about the double 's' [Messenger] fix typo [Messenger] Routing & Inheritance [Cache] Add TLS scheme for Redis connection
* 5.2: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated Fixed table markup [Messenger] Add options for PostgreSQL LISTEN/NOTIFY support Update data_collector.rst [#14728] Be explicit about the double 's' [#14700] Minor rewording Update login_link.rst Added explaination on context in events and initial marking [Messenger] fix typo [Messenger] Routing & Inheritance docs(http-client): fix default retry_failed configuration example [Cache] Add TLS scheme for Redis connection
Seesymfony/symfony#39599.