Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Add TLS scheme for Redis connection#14728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:4.4frommisaert:feat-add-tls-to-redis-cache-adapter
Apr 7, 2021
Merged

[Cache] Add TLS scheme for Redis connection#14728

wouterj merged 1 commit intosymfony:4.4frommisaert:feat-add-tls-to-redis-cache-adapter
Apr 7, 2021

Conversation

@misaert
Copy link
Contributor

@OskarStarkOskarStark modified the milestones:5.3,nextJan 8, 2021
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestFeb 22, 2021
… (misaert)This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.Discussion----------[Cache] Fix Redis TLS scheme `rediss` for Redis connection| Q             | A| ------------- | ---| Branch?       | 5.x| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |symfony/symfony-docs#14728Like#35503 on Symfony Messenger, this will enable TLS support for Redis adapter.The implementation just prefix the host with `tls://` as described here:https://github.com/phpredis/phpredis#connect-openI don't know how to test it because I guess I need a TLS Redis in `src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php`.Commits-------3288897 [Cache] Fix Redis TLS scheme `rediss` for Redis connection
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 22, 2021
edited
Loading

Is that correct? Isn't TLS enabled by using therediss scheme instead?

@misaert
Copy link
ContributorAuthor

No, it is not correct because the implementation has changed over time. I take care of changing this PR to correspond with the choosen implementation 😉

@misaertmisaert changed the title[Cache] Add TLS option for Redis connection[Cache] Add TLS scheme for Redis connectionFeb 22, 2021
@misaert
Copy link
ContributorAuthor

Changed. Do I have to change the destination of the branch to4.4 one?

@nicolas-grekas
Copy link
Member

Yes please, and rebase on 4.4 before.

@misaertmisaert changed the base branch from5.x to4.4February 22, 2021 19:51
@misaert
Copy link
ContributorAuthor

Done.

@OskarStarkOskarStark modified the milestones:next,4.4Feb 22, 2021
@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelFeb 22, 2021
wouterj added a commit that referenced this pull requestApr 7, 2021
@wouterjwouterj merged commit5e69cc3 intosymfony:4.4Apr 7, 2021
@wouterj
Copy link
Member

Hi@misaert! I'm not sure why this PR has been open for quite a while after the code merge. All seems perfect. Thanks for taking care of updating the docs!

misaert reacted with thumbs up emoji

wouterj added a commit that referenced this pull requestApr 8, 2021
* 4.4:  Add troubleshooting for parallel merges to maintainer guide  Update framework.rst  JsonResponse content updated  [#14728] Be explicit about the double 's'  [Messenger] fix typo  [Messenger] Routing & Inheritance  [Cache] Add TLS scheme for Redis connection
wouterj added a commit that referenced this pull requestApr 8, 2021
* 5.2:  Add troubleshooting for parallel merges to maintainer guide  Update framework.rst  JsonResponse content updated  Fixed table markup  [Messenger] Add options for PostgreSQL LISTEN/NOTIFY support  Update data_collector.rst  [#14728] Be explicit about the double 's'  [#14700] Minor rewording  Update login_link.rst  Added explaination on context in events and initial marking  [Messenger] fix typo  [Messenger] Routing & Inheritance  docs(http-client): fix default retry_failed configuration example  [Cache] Add TLS scheme for Redis connection
This was referencedOct 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@misaert@nicolas-grekas@wouterj@OskarStark@maxhelias@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp