Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update login_link.rst#14700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.2fromulinskas:patch-2
Apr 7, 2021
Merged

Update login_link.rst#14700

wouterj merged 1 commit intosymfony:5.2fromulinskas:patch-2
Apr 7, 2021

Conversation

@ulinskas
Copy link
Contributor

Added extra information how to use success handler

@ulinskas
Copy link
ContributorAuthor

@OskarStark Is it still relevant?
Or should I close this PR?

@OskarStark
Copy link
Contributor

@wouterj can you please review this PR? Thanks

wouterj added a commit that referenced this pull requestApr 7, 2021
@wouterjwouterj merged commit29f1436 intosymfony:5.2Apr 7, 2021
@wouterj
Copy link
Member

Thank you@ulinskas! I've slightly reworded this section in8680b94 , but other than that this is perfect :)

I'm a bit interested with the example though: if I'm correct, this URL is clicked on by the user (i.e. it's opened in a browser), in which situation does it make sense to return a JSON response in that case?

@ulinskas
Copy link
ContributorAuthor

@wouterj
Sorry, my mistake.
Probably it should beResponse orRedirectResponse

wouterj added a commit that referenced this pull requestApr 8, 2021
* 5.2:  Add troubleshooting for parallel merges to maintainer guide  Update framework.rst  JsonResponse content updated  Fixed table markup  [Messenger] Add options for PostgreSQL LISTEN/NOTIFY support  Update data_collector.rst  [#14728] Be explicit about the double 's'  [#14700] Minor rewording  Update login_link.rst  Added explaination on context in events and initial marking  [Messenger] fix typo  [Messenger] Routing & Inheritance  docs(http-client): fix default retry_failed configuration example  [Cache] Add TLS scheme for Redis connection
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@wouterjwouterjAwaiting requested review from wouterj

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ulinskas@OskarStark@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp