Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document routing inline requirements and defaults for host#14671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.2fromjulienfalque:routing-host-inline
Dec 9, 2020

Conversation

julienfalque
Copy link
Contributor

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for fast response on closing the PR. This also made me realize your code feature was already merged, congrats!

👍 let's merge this as well :)

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR is ready, but shall we add an example? In the next major version the versionadded directives will be removed 🧐

@wouterj
Copy link
Member

Thank you@julienfalque for documenting the changes you proposed to the Symfony code!

@OskarStark is correct about adding an example (as the versionadded will be removed some time in the future). So I've done exactly that in1ae411b (and also moved the information to the section talking about thehost setting).

OskarStark and julienfalque reacted with heart emoji

@julienfalque
Copy link
ContributorAuthor

Thanks@wouterj and@OskarStark!

@julienfalquejulienfalque deleted the routing-host-inline branchDecember 9, 2020 10:49
wouterj added a commit that referenced this pull requestDec 10, 2020
* 5.2:  Update setup page for Symfony 5.1 - add version  Update setup page for Symfony 5.2 - drop dev  [#14671] Added example of inline host defaults/requirements  [#14672] Updated more docs related to the UserBadge  Update experimental_authenticators : add UserBadge  Document routing inline requirements and defaults for host
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@wouterjwouterjAwaiting requested review from wouterj

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@julienfalque@wouterj@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp